-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.9 support #558
Python 3.9 support #558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 61 61
Lines 3246 3246
=======================================
Hits 2993 2993
Misses 253 253
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I think the main problem here is going to be waiting for pre-built wheels for e.g. pymatgen. I guess we could consider disabling the adapter tests for 3.9 (as they install many extra deps), but I'll convert this to a draft for now. |
I wouldn't disable tests. On another note, I personally don't mind implementing a test for the used Python interpreter version when importing specific parts of the package that are clearly independent, e.g., the adapters versus the server. |
Think this would be the best option, but we would still need to handle how the deps get installed (which in practice means disabling the adapter tests for 3.9) |
3dd4ddf
to
47cefb2
Compare
47cefb2
to
9b5e40b
Compare
These problems have fixed themselves for now, as all of our dependencies now have wheels for 3.9. I can't see anything subtle that we'd have to change in our code base based on a quick read of https://docs.python.org/3.9/whatsnew/3.9.html so this should be good to go. It's a shame dependabot can't do this for us! |
This PR can be used to track Python 3.9 compatibility.
https://docs.python.org/3.9/whatsnew/3.9.html