Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CasperWA/push-protected from v1 to v2.1.0 #573

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2020

Bumps CasperWA/push-protected from v1 to v2.1.0.

Release notes

Sourced from CasperWA/push-protected's releases.

v2.1.0

Changes:

  • Remove use of global cache variable (#22)

Fixes:

  • Perform pushing tags in a separate git push command (#19)

Developer changes:

  • Use action in new release workflow for updating tags and Python package version (#20)
  • Update job names for CI tests of different actions/checkout versions (#21)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) label Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          62       62           
  Lines        3221     3221           
=======================================
  Hits         2956     2956           
  Misses        265      265           
Flag Coverage Δ
#project 91.77% <ø> (ø)
#validator 64.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2212107...d2c43d0. Read the comment docs.

@CasperWA CasperWA self-assigned this Oct 30, 2020
@CasperWA CasperWA force-pushed the dependabot/github_actions/master/CasperWA/push-protected-v2.1.0 branch from edaf65e to 28646a0 Compare October 30, 2020 10:23
dependabot bot and others added 2 commits October 30, 2020 13:05
Update publish workflow to use the new workflow style of
`CasperWA/push-protected@v2`.
@CasperWA CasperWA force-pushed the dependabot/github_actions/master/CasperWA/push-protected-v2.1.0 branch from 28646a0 to b9edb11 Compare October 30, 2020 12:05
@CasperWA CasperWA requested review from shyamd and ml-evs October 30, 2020 13:15
ml-evs
ml-evs previously approved these changes Oct 30, 2020
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nice simplifications here, thanks @CasperWA. I guess the real test will be the next release 😁

.github/workflows/update_docs.sh Outdated Show resolved Hide resolved
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean :) Do we want to wait until we have some more PRs in to do the next release?

@CasperWA
Copy link
Member

Nice and clean :) Do we want to wait until we have some more PRs in to do the next release?

I think it's fine to test this with a patch release already? There are already 15 commits not released on PyPI...

@CasperWA CasperWA merged commit 4e51f4c into master Oct 31, 2020
@CasperWA CasperWA deleted the dependabot/github_actions/master/CasperWA/push-protected-v2.1.0 branch October 31, 2020 00:06
ml-evs pushed a commit that referenced this pull request Oct 31, 2020
Update publish workflow to use the new workflow style of
`CasperWA/push-protected@v2`.

Use action to update changelog.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <[email protected]>
@ml-evs
Copy link
Member

ml-evs commented Oct 31, 2020

Nice and clean :) Do we want to wait until we have some more PRs in to do the next release?

I think it's fine to test this with a patch release already? There are already 15 commits not released on PyPI...

Have just triggered it, let's see how it goes...

@ml-evs
Copy link
Member

ml-evs commented Oct 31, 2020

Have just triggered it, let's see how it goes...

It worked 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants