-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Lark to Django Query converter #61
Added a Lark to Django Query converter #61
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
+ Coverage 76.73% 78.3% +1.56%
=========================================
Files 19 21 +2
Lines 649 719 +70
=========================================
+ Hits 498 563 +65
- Misses 151 156 +5
Continue to review full report at Codecov.
|
Thanks for this @tachyontraveler , looks really useful. Not a Django person, so happy to defer to you, but is there a reason we can't have the same interface as in Would you also be able to run these through |
Thanks for the comments and suggestions, @ml-evs . About the Django transformer: I used the non-generic keywords like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tachyontraveler , thanks for the details, I thought that might be the case. This is clearly useful for anyone using Django, so I'm happy to accept.
Adding some docstrings would be nice but understand time pressures, and don't want to hold you to a higher standard than the mongo equivalent!
Great, thank for the review. I can definitely add the docstring sometime later. |
Additions: