-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator changes: always check unversioned '/versions' and handle rich HTML pages #665
Conversation
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 93.45% 93.30% -0.15%
==========================================
Files 61 61
Lines 3299 3300 +1
==========================================
- Hits 3083 3079 -4
- Misses 216 221 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ccb9cb5
to
db5fc58
Compare
db5fc58
to
aad6b5f
Compare
Changed to low-priority as this is only an issue in cases where the validator should fail anyway, i.e. this PR is just an error message improvement, initially we thought it was bug fix that it was failing because of this |
ae01e5f
to
1bd20b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, cheers @ml-evs !
This PR does two things:
/versions
endpoint, even when passed a versioned URL