-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codecov coverage config file #672
Conversation
Properly set threshold.
This is one of the many incantations I've tried to get this working in the past, so good luck... |
I'd suggest adding a random function somewhere in the code that would break the coverage in a separate commit to test that this actually does anything. |
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 61 61
Lines 3300 3300
=======================================
Hits 3079 3079
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
e16222e adds enough non-covered lines to decrease the overall coverage of the code by 0.12 %. But it's still listed as a pass, since this is below 0.5 % 👍 |
a23c4fa
to
9c025f3
Compare
Note: The documentation on how to fill out the config file is here. |
From this line it seems the fetch depth should be set differently as well. |
I think will work out, so I'll remove the temporary commit (resulting in no code changes) and then it should all be fine. Last question though. Since I renamed the "project" status to "project/optimade", should we rename the flag from project to optimade as well? Or maybe just keep it so that the history on codecov persists? Also, as a summary, I have set all the thresholds to 1%, except for patch, which is set to 5%. Is this fine? |
Use `paths` is codecov config instead of running extra pytest only for validator.
Set thresholds to 1%. Set patch threshold to 5%.
Rename the status of the project flag to optimade.
3575aa5
to
99c0f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @CasperWA, definitely a better way of doing things. I'm happy with these thresholds, we can always tweak them again if need be.
Properly set threshold.
This is implemented with reference to https://github.com/aiidateam/aiida-optimade/blob/develop/.codecov.yml, which seems to work for this PR. (Project coverage decrease of 0.16 % and it's still accepted, only the patch coverage is not accepted due to a difference of more than 0.5 % than from what is expected).