-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manual verification of elements_ratios #76
Fix manual verification of elements_ratios #76
Conversation
Also, add the valid None as response with single datum (StructureResponseOne).
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 85.71% 85.66% -0.06%
==========================================
Files 30 30
Lines 1323 1325 +2
==========================================
+ Hits 1134 1135 +1
- Misses 189 190 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can we make one extra change?
Now that the single entry endpoint can return None when there are no results, can we change the linked line below to if data_available > 1
? This suppresses an error on my server when querying a non-existent structure.
Couple of extra lines needed changing too so I did it myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my changes and merge when you're happy
Thanks @ml-evs - and yeah, I have made several of those changes in my own server as well, simply forgot to add them here. |
I had some issues regarding validation of
elements_ratios
and found out that an equal sign was all that was missing for the comparison againstEPS
.Also, add the valid
None
ornull
as response with single datum (StructureResponseOne
), if it cannot be found, in accordance with the OPTiMaDe spec.