-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some validation QoL tweaks #948
Conversation
de90193
to
fdf81af
Compare
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
==========================================
+ Coverage 92.78% 92.92% +0.13%
==========================================
Files 67 67
Lines 3786 3787 +1
==========================================
+ Hits 3513 3519 +6
+ Misses 273 268 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aab2449
to
97484de
Compare
97484de
to
c6f76d8
Compare
Co-authored-by: Casper Welzel Andersen <[email protected]>
c6f76d8
to
5587980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the remark about the description of EPS the changes seem good to me.
This PR addresses a few ergonomics/QoL concerns with the validator:
elements_ratios
validator (closes 'elements_ratios' model validator uses double-precision machine epsilon - could be relaxed #947)Use set operations in some of the chemical symbol field validators (might revert as it doesn't do quite what I wanted to, doubt there's any real speed boost)Dropped this for now.