Updated validator flags #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/update_validator_flags
branch
from
83468c8 to
1f26a20
Compare
ml-evs
commented
Jul 17, 2020
ml-evs
commented
Jul 17, 2020
ml-evs
force-pushed
the
ml-evs/update_validator_flags
branch
from
013c50d to
5616289
Compare
This is for bats tests. By default, use commit d71275a38f3c0e778408f22b6a2566c1e901793a from optimade-python-tools. This is a temporary fix for `optimade_validator`->`optimade-validator`.
It seems asserts (tests) cannot be run in teardown(), hence the test that the final `optimade-validator ...` call is correct for each test has been moved to each test separately, and the teardown() function now only removes the temporary output file. Also, use the default values correctly for `skip_optional` and `fail_fast`.
This ensures that if running the tests locally, any pip entry-points will be updated correctly for all tests always. Also, use `>` everywhere for writing to the temporary output test file.
Use pseudo-TTY when running Docker to get the pretty printing of BATS testing. Update README part describing the run script to include the DOCKER_BATS_TEST_PATH parameter description.
Use Python 3.8 for the action. Use the newest BATS v1.2.1 and the updated repository paths for BATS extras (assert and support).
CasperWA
force-pushed
the
ml-evs/update_validator_flags
branch
from
115d5ea to
5bbf16e
Compare
CasperWA
force-pushed
the
ml-evs/update_validator_flags
branch
from
e0eca86 to
1781fd8
Compare
|
The latest commit uses |
Closed
CasperWA
approved these changes
Jul 17, 2020
|
merge at will :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for Materials-Consortia/optimade-python-tools#395 to get merged, this PR updates the flags to match the new versions in the validator.