Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of optimade-validator-action v2 #23

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Release of optimade-validator-action v2 #23

merged 5 commits into from
Jul 17, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jul 17, 2020

No description provided.

@ml-evs ml-evs force-pushed the ml-evs/action_v2 branch from d461e2f to e14c919 Compare July 17, 2020 13:49
@ml-evs ml-evs requested a review from CasperWA July 17, 2020 14:10
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ml-evs !

Some minor changes.
Also, we should add a valid range of optimade-python-tools versions for the vMAJOR tags.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ml-evs and others added 2 commits July 17, 2020 15:28
Co-authored-by: Casper Welzel Andersen <[email protected]>
New section "Concerning action versions and `optimade-python-tools`".
This tries to outline which versions of the `optimade` package are valid
for each of the major action versions (also correlating with the valid
OPTIMADE API versions).
README.md Outdated Show resolved Hide resolved
Co-authored-by: Matthew Evans <[email protected]>
tests/test_validator_version.bats Outdated Show resolved Hide resolved
@ml-evs ml-evs force-pushed the ml-evs/action_v2 branch from 1bb4da7 to 5e0fe58 Compare July 17, 2020 16:12
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @ml-evs.

@ml-evs ml-evs merged commit f9dfdab into master Jul 17, 2020
@CasperWA CasperWA deleted the ml-evs/action_v2 branch July 17, 2020 16:19
@CasperWA CasperWA mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants