-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix as type
implementation
#57
Fix as type
implementation
#57
Conversation
It seems to me like there's an issue with the validator when using the Edit: Now also with verbosity 3 getting DEBUG messages as well. |
It looks like the validator is running fine, but then either doesn't set |
Hmm, I tried it locally, and the return code is |
5f98d50
to
f3c70e3
Compare
This ensures the exit code is 0. In Bash, if a negative check is done, and it's not true, the last pipestatus is non-zero. In order to ensure a "correct" pipestatus and scipt exit code, the else clause is added with a "pass" statement, in the form of a colon (:).
This ensures the exit code is correctly set from the pipestatus.
I found the reason for the action to exit with a non-zero code. However, this created some issues with the exit code to be reported in |
Note, currently I'm using a special branch of the |
@ml-evs ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #56.
If
as type
is supplied it is understood that the domain+path constitutes the complete URL to be tested.Hence, only a single validation will be run, and the parameters
all versioned paths
andvalidate unversioned path
have no meaning and will be ignored.This means
as type
take precedence, which is what I would expect.Possibly add: