Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed compound interest with negative balance PLEASE REVIEW #353

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

dev-asya
Copy link
Contributor

@dev-asya dev-asya commented Jan 7, 2025

previously the "Compound Interest" joker would cause a crash when balance was a negative number (thanks to credit card). A fringe case, but still not ideal.
Hopefully now it just does nothing, rather than break the game.

Copy link
Collaborator

@Foegro Foegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an "end" missing after the else statement

Copy link
Contributor Author

@dev-asya dev-asya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - thanks for catching that

@Foegro Foegro merged commit a64dce7 into MathIsFun0:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants