Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): add sysClr branch for Start event #193

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

RoloEdits
Copy link
Contributor

In the current implimentation, the only matching for a:sysClr is Event::Empty, which means a tag like <a:sysClr ... />, with no explicit closing tag. However, there are implementations where there are closing tags, <a:sysClr ... ></a:sysClr>.

<a:clrScheme name="New Office">
            <a:dk1>
                <a:sysClr val="windowText" lastClr="000000"></a:sysClr>
            </a:dk1>
            <a:lt1>
                <a:sysClr val="window" lastClr="FFFFFF"></a:sysClr>
            </a:lt1>
            <a:dk2>
                <a:srgbClr val="44546A"></a:srgbClr>
            </a:dk2>
            <a:lt2>
                <a:srgbClr val="E7E6E6"></a:srgbClr>
            </a:lt2>
            <a:accent1>
                <a:srgbClr val="5B9BD5"></a:srgbClr>
            </a:accent1>
            <a:accent2>
                <a:srgbClr val="ED7D31"></a:srgbClr>
            </a:accent2>
            <a:accent3>
                <a:srgbClr val="A5A5A5"></a:srgbClr>
            </a:accent3>
            <a:accent4>
                <a:srgbClr val="FFC000"></a:srgbClr>
            </a:accent4>
            <a:accent5>
                <a:srgbClr val="4472C4"></a:srgbClr>
            </a:accent5>
            <a:accent6>
                <a:srgbClr val="70AD47"></a:srgbClr>
            </a:accent6>
            <a:hlink>
                <a:srgbClr val="0563C1"></a:srgbClr>
            </a:hlink>
            <a:folHlink>
                <a:srgbClr val="954F72"></a:srgbClr>
            </a:folHlink>
        </a:clrScheme>

This pull request adds a branch in Event::Start that would cover this scenario, matching the srgbClr equivalent that already existed.

@MathNya MathNya merged commit 20cc655 into MathNya:master Jun 4, 2024
1 check passed
@RoloEdits RoloEdits deleted the theme-parse-system-colors branch June 4, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants