Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session.parse #858

Merged
merged 11 commits into from
May 27, 2023
Merged

session.parse #858

merged 11 commits into from
May 27, 2023

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented May 26, 2023

Adding this method which is handy for low-level tests.
Also,

  • Removing unused imports.
  • Adding symbols to mathics.core.systemsymbols

rocky
rocky approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@rocky rocky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The new Symbols in systemsymbols do not seem to be used anywhere yet. This is in anticipation for possible use in the future? Maybe #859. If so, #859 should be been based off of this and merged to this rather than master.

Not a big deal, just something to keep in mind..

Line 15 of session.py:

import mathics.settings

Looks like it is not used anywhere in the module. It probably could be removed.

rocky

This comment was marked as duplicate.

Sign in to view

@mmatera
Copy link
Contributor Author

mmatera commented May 27, 2023

LGTM.

The new Symbols in systemsymbols do not seem to be used anywhere yet. This is in anticipation for possible use in the future? Maybe #859. If so, #859 should be been based off of this and merged to this rather than master.

Not a big deal, just something to keep in mind..

Line 15 of session.py:

import mathics.settings

Looks like it is not used anywhere in the module. It probably could be removed.

OK, let me merge this and then I can remove the unused import.

@mmatera mmatera merged commit 09b0fe5 into master May 27, 2023
@mmatera mmatera deleted the tidy_up_stuff branch May 27, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocky rocky rocky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatera @rocky