-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Polykey.io Theme to Docs #12
Port Polykey.io Theme to Docs #12
Conversation
In the future, please indicate the PR fixes the issue. But I've already done it above. |
Hi @developerdesigner18 in the future, please write your commit as |
hey @developerdesigner18 the navbar does not look exactly the same. It is not seamless. Do you see not only are the colours different, but the sizing is different. The entire thing is not seamless. |
Hey @developerdesigner18 I think there was some misunderstanding on the navbar menu for mobile view. I want to keep the docusaurus menu. Do not change it to the menu in ONLY make it come out from the right instead of the left. Right now the menu is incorrect. It must be the same as it was before with docusaurus. |
We must be able to navigate the documentation like before. |
Also can you not just override the entire navbar component. Use the existing components here: #12 (comment) And override only the ones necessary for the minimal template changes. |
16649e7
to
0f7a740
Compare
Note to self, to push to the remote PR: git fetch origin pull/12/head:feature-navbar
git checkout feature-navbar
git remote add developerdesigner [email protected]:developerdesigner18/Polykey-Docs.git
git push developerdesigner HEAD:Create-New-Navbar-Component |
In total these are the problems:
|
Can you combine your other PR into this? Don't create 2 PRs for these things. Let's see it all together... |
The navbar background colour is |
BTW we use conventional commits. Please follow the same style in the future. |
Hey @developerdesigner18 I want all the fonts in the |
Hey @developerdesigner18 why did you delete the I already changed this last time, why did you end up deleting mine again? |
I have put all the fonts from the location that you have attached here. |
This things is done |
|
No that's not what I see: |
And still no tsx..? |
|
|
We aren't using Nunito Sans, so you can remove that. Open Sans should be used for the font of the content. The roboto should be used for code. I already explained all this in the original issue #6. |
|
@developerdesigner18 there's an extra |
The current branch cannot start.
|
|
@bmamouri please work off this PR first when you start on Polykey-Docs. There's already pre-existing changes that are worth keeping, but the components is likely to require some changes. |
@amydevs consider using GitLab LFS or GitHub LFS to store images and then reference them within the content as if they were normal images on the file system. This avoids the complication of S3, while also potentially allows them to still be rendered in GitHub/GitLab markdown rendering. Cloudflare won't care, as long as the when you clone/pull the repo, the LFS is activated to download those images. |
@bmamouri I've just merged a branch into main regarding fixing image urls, so I'm commenting here as a heads-up to rebase |
Closing this PR because it is outdated and we have the new PR #17 includes the useful work of this PR. Thanks |
Description
Create-Custom-Navbar-Component For Document-site
Fixes #6
Tasks
polykey.io
docusaurus.config.js
in theconfig.themeConfig.navbar.items
array.Final checklist