-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WorkerManager is being reported to be created **after** the agent is already started and reported its status #399
Comments
Reviewing
This is the expected order. Setting the workerManager is synchronous and creating it is properly awaited. So I don't see any async weirdness happening here. So like you said, it's likely cloudwatch just giving is the order slightly wrong due to the outputs being on One thing stands out though. The worker manager is only getting started after |
This allows the relevant domains to access the worker pool for startup operations. Notably `KeyManager` uses this to do key generation. Related #399
This allows the relevant domains to access the worker pool for startup operations. Notably `KeyManager` uses this to do key generation. Related #399
Ok so the There is a usecase to have it available during So I want to examine this later, as it is not a high priority. Currently the |
This is already trivially fixed by #446, because the KeyManager has been replaced with |
Describe the bug
In the deployed testnet, I can see that
WorkerManager: Created WorkerManager
is logged after the STDOUT of the agent. I'm not sure if this is a bug or if its just due to cloud watch reporting the 2 messages at the same time.Do note that the 2 message timestamps are exactly the same, even the milliseconds
2022-07-04T07:13:37.137000+00:00
. It could just due to the fact that the task is set tomode: non-blocking
logging which causes the message to arrive out of order.Part of the problem is that STDOUT and STDERR are interleaved in cloudwatch, so maybe that's the issue too.
Check the code too as we should definitely wait for worker manager to be fully created before we print out the agent status.
To Reproduce
pk agent start
WorkerManager: Created WorkerManager
Expected behavior
Additional context
Notify maintainers
@CMCDragonkai
The text was updated successfully, but these errors were encountered: