Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Iterator KeyPath and Enable Iterator keyAsBuffer and valueAsBuffer #23

Merged
merged 4 commits into from
May 26, 2022

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented May 26, 2022

Description

Several issues being fixed here and merged early outside of the SI work in #19.

The release for now will still be manual.

Issues Fixed

Tasks

  • 1. Updated typedoc generation
  • 2. Canary option was never used
  • 3. Updated jest.config.js to use ts-jest instead of ts-jest/utils
  • 4. Enabled keyAsBuffer and valueAsBuffer options for iterators
  • 5. Changed iterator to return KeyPath
  • 6. Typo for ErrorDBTransactionCommited to ErrorDBTransactionCommitted
  • 7. Added codesee diagrams
  • 8. Updated .gitlab-ci.yml in preparation for native addons
  • 9. Test global environment is synced with TS-Demo-Lib

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai CMCDragonkai force-pushed the feature-keysanditerator branch 3 times, most recently from 2e2724e to f9913c1 Compare May 26, 2022 07:05
@CMCDragonkai CMCDragonkai changed the title Feature keysanditerator Fix Iterator KeyPath and Enable Iterator keyAsBuffer and valueAs(buffer May 26, 2022
@CMCDragonkai CMCDragonkai self-assigned this May 26, 2022
…Buffer options

* Updated typedoc generation
* Canary option was never used
* Updated jest.config.js to use ts-jest instead of ts-jest/utils
* Enabled keyAsBuffer and valueAsBuffer options for iterators
* Changed iterator to return `KeyPath`
* Typo for ErrorDBTransactionCommited to ErrorDBTransactionCommitted
* Added codesee diagrams
* Updated .gitlab-ci.yml in preparation for native addons
* Test global environment is synced with TS-Demo-Lib
@CMCDragonkai CMCDragonkai force-pushed the feature-keysanditerator branch from 4f15333 to 934796f Compare May 26, 2022 07:12
@CMCDragonkai CMCDragonkai changed the title Fix Iterator KeyPath and Enable Iterator keyAsBuffer and valueAs(buffer Fix Iterator KeyPath and Enable Iterator keyAsBuffer and valueAsBuffer May 26, 2022
@CMCDragonkai
Copy link
Member Author

Merging now!

@CMCDragonkai CMCDragonkai merged commit d1edf63 into staging May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant