Iss 225 dbt unit test non default coltypes #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault dtyped columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
data_raw-stageunit_testto A) mock up data in the sql format, and thus B) actually run without error. Closes dbt unit_test can't compile due to aGeometry-typed column #225clean-stage dedupe-logicunit_tests against a model with a geospatial column to test the dedupe logic macro against similar models.data_rawmodels from thedata_raw/schema.ymlclean/schema.ymlto reflect the (ancient) refactoring (from here) that separated the_standardizedand_cleanstage models into separate schemas.Regarding the unit_tests, I'm not too happy with this fix, the tests are much harder to read and quickly identify the differences that are being tested. Hopefully a more elegant solution emerges, but this workaround gets
unit_tests against geospatial models to actually work, which is good enough for now.