Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's giving an InvalidPoint error on f1f2. I took f1f2 parameters from arkworks impl. I also noticed that we've only put a base field and generator when defining the curve. Not sure if/how should we also add other things like:
Or the actual curve equation with parameters
a
andd
is added just in ShortWeierstrass form(witha
andb
)?But then seems we are still missing scalar field.
Also, I think parameters for new_base should be in hex format instead of dec.
ShortWeierstrass form is:
y^2 = x^3 + a * x + b
...will continue tomorrow
cc @MatteoMer @0xKitetsu-smdk lmk what do you think