Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test impl #1

Merged
merged 1 commit into from
Jul 17, 2023
Merged

test impl #1

merged 1 commit into from
Jul 17, 2023

Conversation

dragan2234
Copy link
Collaborator

Currently, it's giving an InvalidPoint error on f1f2. I took f1f2 parameters from arkworks impl. I also noticed that we've only put a base field and generator when defining the curve. Not sure if/how should we also add other things like:

//! * Scalar field: r =
//!   13108968793781547619861935127046491459309155893440570251786403306729687672801
//! * Valuation(q - 1, 2) = 32
//! * Valuation(r - 1, 2) = 5
//! * Curve equation: ax^2 + y^2 =1 + dx^2y^2, where
//!    * a = -5
//!    * d = 45022363124591815672509500913686876175488063829319466900776701791074614335719

Or the actual curve equation with parameters a and d is added just in ShortWeierstrass form(with a and b)?

But then seems we are still missing scalar field.

Also, I think parameters for new_base should be in hex format instead of dec.

ShortWeierstrass form is:
y^2 = x^3 + a * x + b

...will continue tomorrow

cc @MatteoMer @0xKitetsu-smdk lmk what do you think

@MatteoMer
Copy link
Owner

For the curve form, I took the values from arkwork here https://github.com/arkworks-rs/curves/blob/master/ed_on_bls12_381_bandersnatch/src/curves/mod.rs

@MatteoMer MatteoMer merged commit bf1c118 into main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants