Merge pull request #306 from QuantumDancer/add-auditor-update-record-…

…error-handling Add error handling when updating non-existing record
MatterMiners · Aug 9, 2023 · 48daacb · 48daacb
2 parents a2b4bf9 + e513aac
commit 48daacb
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 1 deletion.
diff --git a/tardis/plugins/auditor.py b/tardis/plugins/auditor.py
@@ -85,7 +85,18 @@ async def notify(self, state: State, resource_attributes: AttributeDict) -> None
                 .replace(tzinfo=self._local_timezone)
                 .astimezone(pytz.utc)
             )
-            await self._client.update(record)
+            try:
+                await self._client.update(record)
+            except RuntimeError as e:
+                if str(e).startswith(
+                    "Reqwest Error: HTTP status client error (400 Bad Request)"
+                ):
+                    self.logger.debug(
+                        f"Could not update record {record.record_id}, "
+                        "it probably does not exist in the database"
+                    )
+                else:
+                    raise
 
     def construct_record(self, resource_attributes: AttributeDict):
         """

diff --git a/tests/plugins_t/test_auditor.py b/tests/plugins_t/test_auditor.py
@@ -143,6 +143,46 @@ def test_notify(self):
             self.assertEqual(self.client.add.call_count, 1)
             self.assertEqual(self.client.update.call_count, 1)
 
+        # test exception handling
+        self.client.update.side_effect = RuntimeError(
+            "Reqwest Error: HTTP status client error (400 Bad Request) "
+            "for url (http://127.0.0.1:8000/update)"
+        )
+        run_async(
+            self.plugin.notify,
+            state=DownState(),
+            resource_attributes=self.test_param,
+        )
+
+        self.client.update.side_effect = RuntimeError(
+            "Reqwest Error: HTTP status client error (403 Forbidden) "
+            "for url (http://127.0.0.1:8000/update)"
+        )
+        with self.assertRaises(RuntimeError):
+            run_async(
+                self.plugin.notify,
+                state=DownState(),
+                resource_attributes=self.test_param,
+            )
+
+        self.client.update.side_effect = RuntimeError("Does not match RegEx")
+        with self.assertRaises(RuntimeError):
+            run_async(
+                self.plugin.notify,
+                state=DownState(),
+                resource_attributes=self.test_param,
+            )
+
+        self.client.update.side_effect = ValueError("Other exception")
+        with self.assertRaises(ValueError):
+            run_async(
+                self.plugin.notify,
+                state=DownState(),
+                resource_attributes=self.test_param,
+            )
+
+        self.client.update.side_effect = None
+
     def test_construct_record(self):
         record = self.plugin.construct_record(resource_attributes=self.test_param)