Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Actions for automated docker builds #203

Merged

Conversation

giffels
Copy link
Member

@giffels giffels commented Aug 18, 2021

Docker Hub's Autobuild service has been discontinued for free plans. This pull request enables automated docker builds using GitHub Actions as replacement and fixes #191.

  • Docker builds of tardis tags/releases are tagged as latest and with the corresponding version (e.g. 0.7.0).
  • Docker builds of the master branch are tagged as latest.
  • On all other pull_request and push events images are build, but not pushed into the docker hub registry.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #203 (66940b5) into master (bd55dab) will not change coverage.
The diff coverage is n/a.

❗ Current head 66940b5 differs from pull request most recent head d49525f. Consider uploading reports for the commit d49525f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          42       42           
  Lines        1795     1795           
=======================================
  Hits         1787     1787           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd55dab...d49525f. Read the comment docs.

@giffels giffels marked this pull request as ready for review August 18, 2021 12:36
@giffels giffels requested review from a team, maxfischer2781 and HerrHorizontal and removed request for a team August 18, 2021 12:37
HerrHorizontal
HerrHorizontal previously approved these changes Aug 18, 2021
Copy link

@HerrHorizontal HerrHorizontal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing the script as a multi-line string seems more maintainable to me. I've added two possibilities; perhaps having an actual script inside the containers folder might be an idea as well?

.github/workflows/docker-builds.yml Outdated Show resolved Hide resolved
@giffels giffels force-pushed the enable-ghactions--docker-builds branch from 078c750 to 236f4cc Compare September 1, 2021 15:03
@giffels
Copy link
Member Author

giffels commented Sep 1, 2021

Storing the script as a multi-line string seems more maintainable to me. I've added two possibilities; perhaps having an actual script inside the containers folder might be an idea as well?

Thanks for your suggestion. I took the pathlib variant.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

● As I see it, yes. 🎱

@giffels giffels merged commit 2753653 into MatterMiners:master Sep 3, 2021
@giffels giffels deleted the enable-ghactions--docker-builds branch September 3, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerhub auto-builds discontinued for free plans
5 participants