-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub Actions for automated docker builds #203
Enable GitHub Actions for automated docker builds #203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 42 42
Lines 1795 1795
=======================================
Hits 1787 1787
Misses 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storing the script as a multi-line string seems more maintainable to me. I've added two possibilities; perhaps having an actual script inside the containers
folder might be an idea as well?
d49525f
to
078c750
Compare
Co-authored-by: Max Fischer <[email protected]>
078c750
to
236f4cc
Compare
Thanks for your suggestion. I took the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
● As I see it, yes. 🎱
Docker Hub's Autobuild service has been discontinued for free plans. This pull request enables automated docker builds using GitHub Actions as replacement and fixes #191.
tardis
tags/releases are tagged aslatest
and with the corresponding version (e.g.0.7.0
).master
branch are tagged aslatest
.pull_request
andpush
events images are build, but not pushed into the docker hub registry.