Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure python3.6 compatibilty of fastapi #264

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

giffels
Copy link
Member

@giffels giffels commented Sep 16, 2022

This pull request ensures python3.6 compatibility of the fastapi package. According to
https://twitter.com/fastapi/status/1570123136472940550?s=46&t=vyEKlN_AhlwIp-C4-tTIsw support for python3.6 is dropped in version 0.84.0.

@giffels giffels added the potential problem Avoid foreseeable misuse label Sep 16, 2022
@giffels giffels self-assigned this Sep 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #264 (8ef2c48) into master (f9b37ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          55       55           
  Lines        2262     2262           
=======================================
  Hits         2236     2236           
  Misses         26       26           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@giffels giffels marked this pull request as ready for review September 16, 2022 10:08
@giffels giffels requested review from a team, eileen-kuehn and mschnepf and removed request for a team September 16, 2022 10:08
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaks in
approves
sneaks out

Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw you are still waiting on my review 🐌 Here it finally comes 🚀 : Go for it! 👍

@giffels
Copy link
Member Author

giffels commented Sep 27, 2022

Thanks a lot.

@giffels giffels merged commit 459f3de into MatterMiners:master Sep 27, 2022
@giffels giffels deleted the python36-compat branch September 27, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential problem Avoid foreseeable misuse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants