Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken deployment docker builds #275

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Fix broken deployment docker builds #275

merged 2 commits into from
Jan 9, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Jan 9, 2023

Currently, the docker builds of rocky linux containers used for deployment tests is currently broken. This can be fixed by installing epel-release before installing curl. This pull request simply change the order to install curl on rocky linux.

@giffels giffels added the bug Something isn't working label Jan 9, 2023
mschnepf
mschnepf reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@mschnepf mschnepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would RUN yum -y install epel-release && yum -y install curl && yum clean all also be possible? That would avoid an extra filesystem layer for the container.

@giffels giffels requested review from a team, maxfischer2781 and eileen-kuehn and removed request for a team January 9, 2023 09:03
@giffels
Copy link
Member Author

giffels commented Jan 9, 2023

Would RUN yum -y install epel-release && yum -y install curl && yum clean all also be possible? That would avoid an extra filesystem layer for the container.

Yes, this will work as well. Will fix it. Thanks, for the comment

@giffels giffels requested a review from mschnepf January 9, 2023 09:11
maxfischer2781
maxfischer2781 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mschnepf
mschnepf approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mschnepf mschnepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks for fixing 😄

@giffels giffels merged commit 5832dbe into MatterMiners:master Jan 9, 2023
@giffels giffels deleted the fix-deployment-tests branch January 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschnepf mschnepf mschnepf approved these changes

@maxfischer2781 maxfischer2781 maxfischer2781 approved these changes

@eileen-kuehn eileen-kuehn Awaiting requested review from eileen-kuehn eileen-kuehn was automatically assigned from MatterMiners/review

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giffels @maxfischer2781 @mschnepf