Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions #282

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Conversation

giffels
Copy link
Member

@giffels giffels commented Feb 7, 2023

This pull requests addresses warnings about the migration of GitHub actions from nodejs:12 to nodejs:16.

Like

setup-docker-builds
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. 
For more information see: 
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

and

 setup-docker-builds
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. 
For more information see: 
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@giffels giffels force-pushed the update-github-actions branch from 88e7430 to 15fbd71 Compare February 7, 2023 09:45
@giffels giffels added the Improvement Code Improvements label Feb 7, 2023
@giffels giffels requested review from a team, rfvc and RHofsaess and removed request for a team February 7, 2023 09:47
@giffels giffels marked this pull request as ready for review February 7, 2023 09:47
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 98.88% // Head: 98.88% // No change to project coverage 👍

Coverage data is based on head (d6ee17d) compared to base (248cd6e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          56       56           
  Lines        2328     2328           
=======================================
  Hits         2302     2302           
  Misses         26       26           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@RHofsaess RHofsaess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine if the tests are okay with it :D
👍

Copy link
Contributor

@rfvc rfvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the actions, @giffels. As the checks you updated are all green and this is addressed in #279, I'm fine with merging.

@giffels giffels added this pull request to the merge queue Feb 13, 2023
Merged via the queue into MatterMiners:master with commit 74cb920 Feb 13, 2023
@giffels giffels deleted the update-github-actions branch February 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants