Fix handling of squeue call with invalid jobid #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 55 55
Lines 2222 2225 +3
=======================================
+ Hits 2197 2200 +3
Misses 25 25 ☔ View full report in Codecov by Sentry. |
giffels
added a commit
to giffels/tardis
that referenced
this pull request
Dec 18, 2023
giffels
requested review from
a team,
maxfischer2781 and
eileen-kuehn
and removed request for
a team
maxfischer2781
previously approved these changes
Dec 18, 2023
giffels
force-pushed
the
fix/squeue-invalid-jobid
branch
from
5ff342a to
d105f23
Compare
maxfischer2781
approved these changes
Dec 22, 2023
eileen-kuehn
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a job is already completed and only one non-existing job id is provided the
squeuecommand is failing with exit code 1 and it prints "Invalid job id specified" to stderr. If two or more non-existing job ids or a mixture of existing ones and non-existings jobs are provided,squeuecommand succeeds.This pull request is adjusting the handling of failed
squeuecommands correspondigly.Thanks to @rodwalker for reporting it.