Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS x86 Code Signing issues #766

Closed
Matthew-McRaven opened this issue Jan 16, 2025 · 1 comment
Closed

Mac OS x86 Code Signing issues #766

Matthew-McRaven opened this issue Jan 16, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Matthew-McRaven
Copy link
Owner

See Stan's error log.

The app passes both of the following commands and only crashes at startup.

codesign -vvv --verify <path>/pepp.app
spctl -a -vvv -t install <path>/pepp.app

The highlight on the following line makes me think I missed an entitlement related to JIT code.
---> JS JIT generated code 10e0fa000-10e0fb000 [ 4K] r-x/rwx SM=PRV

@Matthew-McRaven Matthew-McRaven added the bug Something isn't working label Jan 16, 2025
@Matthew-McRaven Matthew-McRaven added this to the Pepp 10.9 milestone Jan 16, 2025
@Matthew-McRaven Matthew-McRaven moved this to In Progress in Pepp Jan 16, 2025
Matthew-McRaven added a commit that referenced this issue Jan 16, 2025
While we are not electron, the following issues points out some steps to fix notarization:
electron-userland/electron-builder#3926

On Stan's machine Pepp passes both notarization and codesigning on his machine.
This means there is a runtime issue with the app, likely related to the JS JIT stuff.

Maybe closes #766. Will have to wait for CI passing to know for sure.
Matthew-McRaven added a commit that referenced this issue Jan 16, 2025
While we are not electron, the following issues points out some steps to fix notarization:
electron-userland/electron-builder#3926

On Stan's machine Pepp passes both notarization and codesigning on his machine.
This means there is a runtime issue with the app, likely related to the JS JIT stuff.

Maybe closes #766?
Will have to wait for CI passing and cutting a release to be sure.
Matthew-McRaven added a commit that referenced this issue Jan 16, 2025
While we are not electron, the following issues points out some steps to fix notarization:
electron-userland/electron-builder#3926

On Stan's machine Pepp passes both notarization and codesigning on his machine.
This means there is a runtime issue with the app, likely related to the JS JIT stuff.

Maybe closes #766?
Will have to wait for CI passing and cutting a release to be sure.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pepp Jan 16, 2025
@Matthew-McRaven
Copy link
Owner Author

Got confirmation from Stan that this fixed the issue on x86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant