Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some styling inconsistencies #17

Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open

Fixing some styling inconsistencies #17

wants to merge 97 commits into from

Conversation

Mau-MD
Copy link
Owner

@Mau-MD Mau-MD commented Jul 20, 2022

App Context

Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.

PR Context

Thumbnail image inside the resource card looks bad quality. Also all thumbnails have black bars. Navbar doesn't really work. And the course popover still has the intermediate level, even if it's not being calculated anymore

This PR

Fixes all the things that were mentioned above
CleanShot 2022-07-19 at 17 15 03@2x

Next

Calculate the course progress inside the backend

IMPORTANT:

Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: Making images taking a fixed about of space

How to preview a PR on Vercel

  • Go to /login and log in with username admin and password admin123
  • Go to /dashboard

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-u ✅ Ready (Inspect) Visit Preview Jul 20, 2022 at 0:16AM (UTC)

@Mau-MD Mau-MD requested review from ImaMonsta and nosoyilse July 20, 2022 00:16
@Mau-MD Mau-MD added the waiting for another pr Another PR needs to be approved before this gets reviewed label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for another pr Another PR needs to be approved before this gets reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants