Fixing a bug with undefined images that was making the app crash #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a parse json object
…oid users unfollowing users when they are looking at another profile
…re on another profile
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nosoyilse
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
Whenever you were in the Feed page and you tried to click on the dashboard page, the app would crash since the images gets undefined.
This PR
Adds a fallback image and a lot of clauses to ensure the image exists, and if not, then shows the fallback picture
Next
Reuse a component to add course preview
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: adding fallback image when no image is available
How to preview a PR on Vercel
/loginand log in with usernameadminand passwordadmin123/dashboard