Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing the delete course modal component to be able to preview courses when trying to clone them #51

Merged
merged 281 commits into from
Aug 5, 2022

Conversation

Mau-MD
Copy link
Owner

@Mau-MD Mau-MD commented Aug 5, 2022

App Context

Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.

PR Context

Right now we have a component that displays all the resources when we want to delete a course and give feedback. This same component can be used as a Preview Modal so the user can see how the course would look like before actually clone it.

This PR

Changes a little bit the logic of that component to be able to display resources without actually selecting them.

CleanShot 2022-08-05 at 09 26 41

Next

Make some UI changes to make it look better.

IMPORTANT:

Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: changing component logic so it's optional to receive a onClick function

How to preview a PR on Vercel

  • Go to /login and log in with username admin and password admin123
  • Go to /dashboard

Mau-MD added 27 commits July 29, 2022 09:30
…oid users unfollowing users when they are looking at another profile
@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-u ❌ Failed (Inspect) Aug 5, 2022 at 4:27PM (UTC)

@Mau-MD Mau-MD merged commit 4acaf7b into main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants