Adding infinite scrolling and changing useQuery to useInfiniteQuery to handle this #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid users unfollowing users when they are looking at another profile
…re on another profile
… not only used to delete courses anymore
…ing inside learning dashboard
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nosoyilse
approved these changes
Aug 5, 2022
| @@ -44,8 +45,23 @@ course.post("/new", async (req: RequestWUser, res, next) => { | |||
|
|
|||
| course.get("/me", async (req: RequestWUser, res, next) => { | |||
| const { user } = req; | |||
| const { limit, skip } = req.query; | |||
|
|
|||
| if ( | |||
There was a problem hiding this comment.
same here, could be extracted to a utils function!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
Right now all the courses are fetched all at once, this means that if you have 100 courses, they all going to be fetched at the same time, making the app feel slow.
This PR
Changes
useQuerytouseInfiniteQuerymaking it easy to handle this type of logic. It also adds a function to detect if the user has scrolled all the way down, and also a debounce functionCleanShot.2022-08-05.at.09.35.10.mp4
Next
Add a course searchbar!
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: adding skip and limit to course fetch so it can support pagination
How to preview a PR on Vercel
/loginand log in with usernameadminand passwordadmin123/dashboard