-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding form to let the users create a new course from scratch #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes with similar name
…ows featured courses
…o fetch featured courses and display them on the frontend
…utton exists somewhere else in the ap
…eir own custom courses
…ew form from scratch
… inside a state to be able to render embed videos
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nosoyilse
approved these changes
Aug 5, 2022
import { Field, Form, Formik } from "formik"; | ||
|
||
// export const youtubeRegExp = | ||
// /^.*(youtu.be\/|v\/|u\/\w\/|embed\/|watch\?v=|&v=|\?v=)([^#&?]*).*/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this is not used we can delete
|
||
// export const youtubeRegExp = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete here! good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
Right now all the courses are made automatically by an algorithm. There is no way a user can create its own custom course with its own youtube tutorials
This PR
Adds a form where users can input youtube videos. It also extends
Yup
library by adding a custom youtube link validator with regex, and after validating it, the UI displays an embed video.CleanShot.2022-08-05.at.09.57.03.mp4
Next
Create the backend routes and logic to receive these information and create a custom course.
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: Adding create new course from scratch route and component
How to preview a PR on Vercel
/login
and log in with usernameadmin
and passwordadmin123
/dashboard