Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding E2E Cypress Test to ensure the app is working correctly! #63

Merged
merged 345 commits into from
Aug 5, 2022

Conversation

Mau-MD
Copy link
Owner

@Mau-MD Mau-MD commented Aug 5, 2022

App Context

Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.

PR Context

Right now almost all test have been manual. This is not a good practice since we can break the application without even noticing it

This PR

This adds automated tests on core features that ensures the app is working as normal.

Next

Add guided tour stretch feature!

IMPORTANT:

Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here:

How to preview a PR on Vercel

  • Go to /login and log in with username admin and password admin123
  • Go to /dashboard

Mau-MD added 30 commits July 18, 2022 11:04
Mau-MD added 27 commits August 1, 2022 11:49
… inside a state to be able to render embed videos
@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-u ❌ Failed (Inspect) Aug 5, 2022 at 5:37PM (UTC)

Copy link
Collaborator

@nosoyilse nosoyilse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing that you were able to add tests!

I think it is a better practice to add the test in the same PR as the functionality, but regardless is very good that you had time to add this

@Mau-MD Mau-MD merged commit 6bd815b into main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants