-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding graph visualization to let the users know how suggested a course is #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts to delete a course
…it didn't like when deleting a course
…ific course that wants to be deleted
…n't like when deleting a course
…ne it didn't like when deleting a course
…n displaying on a grid
… user can delete a course
…end to delete a course given its id inside the delete course moda
…t exist, it creates one.
…were shared when a user clones a course
…al ranking given a video query
…en touring the website
…r has already seen that tour
… detects if the user has seen the tour before or not
…frequency of the friends suggestions
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nosoyilse
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
Right now the suggestions badges doesn't display how recommended a course is. It just says its name. Would be nice to have some sort of visual representation to let the user know this data.
This PR
Adds
VictoryChart
library that helps to display a graph with all the courses frequency. This enables the user to know which course is more frequent among the users it follows.Next
Fix final bugs!
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: installing victory chart to display graphs inside course suggestion
How to preview a PR on Vercel
/login
and log in with usernameadmin
and passwordadmin123
/dashboard