Fixed useTour displaying infinitely on Hub Page, Infinite Scroll not triggering inside featured courses and loading status not showing on create course from scratch page #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it didn't like when deleting a course
…ific course that wants to be deleted
…n't like when deleting a course
…ne it didn't like when deleting a course
…n displaying on a grid
… user can delete a course
…end to delete a course given its id inside the delete course moda
…t exist, it creates one.
…were shared when a user clones a course
…al ranking given a video query
…then normalize the results so it can be used for ranking
…nal ranking to create a final ranking score
…lRanking that combines both external and internal ranking
…r has already seen that tour
… detects if the user has seen the tour before or not
…frequency of the friends suggestions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nosoyilse
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
The guided tour displays every time the users is on the hub page.
Infinite scroll is not detecting the user scrolling to the bottom inside Featured Course Page
When creating a custom course from scratch, it doesnt show a loading state nor it redirects when finished.
This PR
Fixes all of the above
Next
Add try catch to all async functions inside the backend so it doesnt crash when something happens
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: adding key to useTour so it doesnt display twice when reloading the page
How to preview a PR on Vercel
/loginand log in with usernameadminand passwordadmin123/dashboard