-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Library files aren't supposed to be executable
Signed-off-by: Gilles Peskine <[email protected]>
- Loading branch information
1 parent
dedff7a
commit 280165c
Showing
2 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Bugfix | ||
* Library files installed after a CMake build no longer have execute | ||
permission. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
280165c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's not wrong, this change still breaks RPM packaging of mbedTLS at Fedora. The thread "why do have shared libs 755 perms?" explains the background at Fedora.
280165c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robert-scheck Given that this is a quirk of rpm or Fedora packaging, I think it's up to Fedora build scripts to handle it.
280165c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's why I suggested https://src.fedoraproject.org/rpms/mbedtls/pull-request/1#request_diff for Fedora.