Skip to content

Commit

Permalink
Library files aren't supposed to be executable
Browse files Browse the repository at this point in the history
Signed-off-by: Gilles Peskine <[email protected]>
  • Loading branch information
gilles-peskine-arm committed Jul 2, 2020
1 parent dedff7a commit 280165c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions ChangeLog.d/cmake-install.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix
* Library files installed after a CMake build no longer have execute
permission.
2 changes: 1 addition & 1 deletion library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ foreach(target IN LISTS target_libraries)
PRIVATE ${thirdparty_def})
install(TARGETS ${target}
DESTINATION ${LIB_INSTALL_DIR}
PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE)
PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ)
endforeach(target)

add_custom_target(lib DEPENDS mbedcrypto mbedx509 mbedtls)
Expand Down

3 comments on commit 280165c

@robert-scheck
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's not wrong, this change still breaks RPM packaging of mbedTLS at Fedora. The thread "why do have shared libs 755 perms?" explains the background at Fedora.

@gilles-peskine-arm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robert-scheck Given that this is a quirk of rpm or Fedora packaging, I think it's up to Fedora build scripts to handle it.

@robert-scheck
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.