-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RFC5280 does not state that the `revocationDate` should be checked. In addition, when no time source is available (i.e., when MBEDTLS_HAVE_TIME_DATE is not defined), `mbedtls_x509_time_is_past` always returns 0. This results in the CRL not being checked at all. https://tools.ietf.org/html/rfc5280 Signed-off-by: Raoul Strackx <[email protected]>
- Loading branch information
1 parent
b21b1f5
commit 3529f78
Showing
7 changed files
with
34 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Bugfix | ||
* A CRL's "revocationDate" entry field is no longer checked to be in the | ||
past. This brings the implementation in line with RFC 5280. Note that | ||
this also is a security fix in environments where the local clock cannot | ||
be trusted (e.g., in an Intel SGX enclave). Reported by Raoul Strackx & | ||
Jethro Beekman. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
-----BEGIN X509 CRL----- | ||
MIIBrzCBmDANBgkqhkiG9w0BAQUFADA7MQswCQYDVQQGEwJOTDERMA8GA1UECgwI | ||
UG9sYXJTU0wxGTAXBgNVBAMMEFBvbGFyU1NMIFRlc3QgQ0EYDzI5OTkxMjMxMjMw | ||
MDAwWhgPMzAxMDAxMDEyMzAwMDBaMCgwEgIBARcNMTEwMjEyMTI0NDA3WjASAgED | ||
Fw0xMTAyMTIxMjQ0MDdaMA0GCSqGSIb3DQEBBQUAA4IBAQCOs/sekrnS0yDIP5BE | ||
MKYMgywqm4IT8hy/pmvqSxFNOC1MF8lLiQ4SPtQvEpCW9mwZ5w+sT/u01Yb2KmQB | ||
OpZGV21o6tvil8byMb3hsc4O11xbMVSHBG0045MPRaW8Ik9SMLS5IE74hXaK5l+y | ||
L9kf4RHZon/tl9OdiseRVb+iEMpGPsHLHZsF3NuPpXAVizu6jHaf4SMIAQ2IjLMy | ||
mmHS9VaMSH+p20fDgDX42uNi+wYGiW9ezCD/oD38dY+XOoIhknWyOTNvzM3bpv0+ | ||
v1WF2ZVksiNcteSICPXcEAnEfmjmcwYoqVOYxd6XH8eQTmnxf7FoUv1jTD7FYEPR | ||
NBLr | ||
-----END X509 CRL----- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters