Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile should be warning-free (x64) #197

Closed
shuffle2 opened this issue May 25, 2015 · 1 comment
Closed

compile should be warning-free (x64) #197

shuffle2 opened this issue May 25, 2015 · 1 comment

Comments

@shuffle2
Copy link

When compiling mbedtls-1.4 with VS2015 targeting amd64 with default config.h, the following warnings are reported:

1>  x509_crl.c
mbedtls\library\ssl_srv.c(1429): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data
mbedtls\library\ssl_srv.c(1538): warning C4267: '-=': conversion from 'size_t' to 'unsigned int', possible loss of data
mbedtls\library\ssl_tls.c(1555): warning C4267: 'initializing': conversion from 'size_t' to 'unsigned char', possible loss of data
1>  x509_crt.c
1>  x509_csr.c
mbedtls\library\net.c(205): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data
mbedtls\library\ssl_tls.c(5834): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data
mbedtls\library\ssl_tls.c(5841): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
mbedtls\library\ssl_tls.c(5846): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
mbedtls\library\ssl_tls.c(5854): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data
mbedtls\library\net.c(304): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data
1>  x509write_crt.c
mbedtls\library\net.c(455): warning C4133: 'function': incompatible types - from 'int *' to 'char *'

All except the last one (C4133) also occurred on VS2013. The size_t warnings, at least, should be taken care of.

@shuffle2 shuffle2 changed the title compile should be warning-free compile should be warning-free (x64) May 25, 2015
@mpg
Copy link
Contributor

mpg commented Jul 1, 2015

Thanks for your report! I just fixed all warnings from VS2015 on Win64 in the upcoming 2.0.

@mpg mpg closed this as completed Jul 1, 2015
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Dec 18, 2018
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Sep 3, 2019
…attributes-and-slots

Tidy up attribute management inside psa_crypto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants