Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLARSSL_CIPHER_ID_3DES never used #198

Closed
evvliet opened this issue May 26, 2015 · 1 comment
Closed

POLARSSL_CIPHER_ID_3DES never used #198

evvliet opened this issue May 26, 2015 · 1 comment

Comments

@evvliet
Copy link

evvliet commented May 26, 2015

In include/polarssl/cipher.h a cipher_id_t value is defined for POLARSSL_CIPHER_ID_3DES but it is actually never used.
I would have expected it to be used in library/cipher_wrap.c by des_ede3_info but that uses POLARSSL_CIPHER_ID_DES instead.

I'm not entirely sure if it can safely be omitted (from the header file) or changed. If not, it might be convenient to mark it as /* Unused! */.

@mpg
Copy link
Contributor

mpg commented Jun 2, 2015

Good catch. I'll mark it as unused in the 1.3 branch, and change des_ede3_info to use it in the 2.0 branch. Thanks for your report.

@mpg mpg closed this as completed Jun 2, 2015
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Dec 18, 2018
PSA Crypto Storage backend implementation over PSA ITS APIs (Mbed-TLS#198)
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Sep 3, 2019
…eta-merge_development_20190801

Merge mbed-crypto/development into psa-api-1.0-beta
iameli pushed a commit to livepeer/mbedtls that referenced this issue Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants