Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible unbalanced parenthesis #4217

Closed
mbeniamino opened this issue Mar 11, 2021 · 2 comments · Fixed by #4219
Closed

Possible unbalanced parenthesis #4217

mbeniamino opened this issue Mar 11, 2021 · 2 comments · Fixed by #4219
Labels

Comments

@mbeniamino
Copy link

Running a translation tool I get this warning while parsing this library:

Unbalanced opening parenthesis in C++ code (or abuse of the C++ preprocessor)

here:

https://github.com/ARMmbed/mbedtls/blob/1c54b5410fd48d6bcada97e30cac417c5c7eea67/library/ecp.c#L2449

Looking at the code it seems to me it's right, but that line is compiled only when MBEDTLS_ECP_RANDOMIZE_MXZ_ALT is defined and in my use case this is false, so I haven't actually tried and checked.

@stevew817
Copy link
Contributor

You would be right. This one's on me, probably due to copy-paste error when transposing the patch. Fix incoming.

@stevew817
Copy link
Contributor

Hang on... No, it's not actually on me. I assumed it was since I touched the ECP_xxx_ALT functionality last. Nevertheless, I'll open a PR for you.

stevew817 added a commit to stevew817/mbedtls that referenced this issue Mar 29, 2021
stevew817 added a commit to stevew817/mbedtls that referenced this issue Mar 29, 2021
daverodgman added a commit to stevew817/mbedtls that referenced this issue Apr 27, 2021
daverodgman pushed a commit to daverodgman/mbedtls that referenced this issue Apr 27, 2021
daverodgman added a commit to daverodgman/mbedtls that referenced this issue Apr 27, 2021
daverodgman added a commit to daverodgman/mbedtls that referenced this issue Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants