Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ecp_mod_p256k1() #7258

Closed
yanesca opened this issue Mar 10, 2023 · 1 comment · Fixed by #7427
Closed

Add unit tests for ecp_mod_p256k1() #7258

yanesca opened this issue Mar 10, 2023 · 1 comment · Fixed by #7427
Assignees
Labels
component-crypto Crypto primitives and low-level interfaces enhancement size-s Estimated task size: small (~2d)

Comments

@yanesca
Copy link
Contributor

yanesca commented Mar 10, 2023

The task is to add unit tests for ecp_mod_p256k1(). This function reduces the input modulo secp256k1_p. The result of ecp_mod_p256k1() is not always canonical, use mpi_mod_mpi() to get a canonical representative for easier testing.

Only cases where the input is non-negative and at most twice as long as the modulus. (This is because soon these will be replaced by their fixed width _raw counterparts.)

@yanesca yanesca added enhancement component-crypto Crypto primitives and low-level interfaces size-s Estimated task size: small (~2d) labels Mar 10, 2023
@minosgalanakis minosgalanakis self-assigned this Apr 5, 2023
@yanesca
Copy link
Contributor Author

yanesca commented Apr 17, 2023

@minosgalanakis according to our process, the PRs should be on the board and not the issues. Could you please remove this from the board and add the PR instead?

@github-project-automation github-project-automation bot moved this to ECP Optimised reduction - Montgomery and Koblitz in Backlog for Mbed TLS Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-crypto Crypto primitives and low-level interfaces enhancement size-s Estimated task size: small (~2d)
Projects
Status: ECP Optimised reduction - Montgomery and Koblitz
Development

Successfully merging a pull request may close this issue.

2 participants