ECP: Add Unit Tests for secp256k1 #7427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minosgalanakis
added
enhancement
needs-review
|
@minosgalanakis this is a deliverable for this quarter, it should have a |
minosgalanakis
force-pushed
the
ecp/7258_ecp_mod_p256K1_add_test_cases
branch
from
94db26c to
f2568ca
Compare
|
As before it is based on PR #7425 . Please review only last 3 commits if need to. It will rebased after #7425 has been merged. |
minosgalanakis
force-pushed
the
ecp/7258_ecp_mod_p256K1_add_test_cases
branch
from
f2568ca to
410a061
Compare
minosgalanakis
removed
the
needs-preceding-pr
|
PR Rebased on latest development. Ready to review |
paul-elliott-arm
requested changes
Apr 21, 2023
library/ecp_curves.c
Outdated
| @@ -4618,6 +4618,8 @@ int mbedtls_ecp_mod_p224k1(mbedtls_mpi *); | |||
| #endif | |||
| #if defined(MBEDTLS_ECP_DP_SECP256K1_ENABLED) | |||
| static int ecp_mod_p256k1(mbedtls_mpi *); | |||
| MBEDTLS_STATIC_TESTABLE | |||
| int ecp_mod_p256k1(mbedtls_mpi *); | |||
There was a problem hiding this comment.
Shouldn't this be:
Suggested change
| int ecp_mod_p256k1(mbedtls_mpi *); | |
| int mbedtls_ecp_mod_p256k1(mbedtls_mpi *); |
minosgalanakis
force-pushed
the
ecp/7258_ecp_mod_p256K1_add_test_cases
branch
from
410a061 to
afca0d5
Compare
gabor-mezei-arm
previously approved these changes
Apr 25, 2023
gabor-mezei-arm
removed
the
needs-reviewer
This patch introduces basic unit-testing for the `ecp_mod_p256k1()`. The method is exposed through the ecp_invasive interface, and the standard testing data is being provided by the python framework. Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
…192k1` Signed-off-by: Minos Galanakis <[email protected]>
minosgalanakis
force-pushed
the
ecp/7258_ecp_mod_p256K1_add_test_cases
branch
from
afca0d5 to
4dfed0a
Compare
paul-elliott-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7258
Gatekeeper checklist