Avoid a potential NULL dereference. #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that the code looks better after your patch, but I disagree there was a NULL dereference before: only the value of the pointer is accessed, not the value it points to. |
|
I applied a change that fixes the problem in a slightly different way (your patch still leaves a dangling |
gilles-peskine-arm
pushed a commit
to gilles-peskine-arm/mbedtls
that referenced
this pull request
Sep 3, 2019
Add mock tests for hooks for secure element drivers
hanno-becker
pushed a commit
to hanno-becker/mbedtls
that referenced
this pull request
Apr 10, 2021
Simplify MPS writer and extended writer
iameli
pushed a commit
to livepeer/mbedtls
that referenced
this pull request
Dec 5, 2023
avoid warning 'The macro AC_TRY_LINK is obsolete.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a couple pointer accesses to after the NULL checks.