-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalize Travis builds #3218
Merged
gilles-peskine-arm
merged 24 commits into
Mbed-TLS:development
from
gilles-peskine-arm:travis-rationalize
May 4, 2020
Merged
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
97bea01
all.sh: run selftest in the full config and with ASan
gilles-peskine-arm 60f267b
all.sh: make the arm-gcc cross-compiler prefix configurable
gilles-peskine-arm c9cdd21
Travis: don't test with both gcc and clang
gilles-peskine-arm d0f543a
Travis: split the build into three parallel jobs
gilles-peskine-arm b49a457
Travis: move doxygen dependencies into the "sanity" job
gilles-peskine-arm a38f368
Travis: run Pylint
gilles-peskine-arm 3c7ffd7
Travis: call all.sh for sanity checks
gilles-peskine-arm dc56675
Travis: call all.sh for the default-configuration build
gilles-peskine-arm a2d3ec2
Travis: replace "default configuration by "full configuration"
gilles-peskine-arm a5ced5b
Travis: install gnutls-bin for all jobs
gilles-peskine-arm 5dcfb94
Travis: call all depends_* tests
gilles-peskine-arm f2f39dd
Travis: add a baremetal build
gilles-peskine-arm 129d041
Travis: add a build on macOS
gilles-peskine-arm af387e0
check-files: support Windows .bat files
gilles-peskine-arm a4a8f04
Add a simple build script for Windows with Visual Studio
gilles-peskine-arm 0402510
Travis: add a build with Visual Studio on Windows
gilles-peskine-arm 23d249a
Travis: Windows: target Visual Studio 2017
gilles-peskine-arm b97a044
Travis: Windows: install Python 3 and run generate_psa_constants.py
gilles-peskine-arm 10cb160
Travis: rebalance the Linux builds
gilles-peskine-arm 6d06134
Rename --arm-gcc-prefix to --arm-none-eabi-gcc-prefix
gilles-peskine-arm 6537588
all.sh: build_arm_none_eabi_gcc: do optimize
gilles-peskine-arm 6e2fb86
all.sh: add a Cortex-M0+ build
gilles-peskine-arm 18487f6
all.sh: on arm builds (GCC or Arm Compiler), show the code size
gilles-peskine-arm 907211d
Travis: do both a Cortex-A build and a Cortex-M0+ build
gilles-peskine-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this change, change the name of the component? component_build_arm_gcc(_cross_compiler) ?
Same comment for the components below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, and I'd prefer to defer such a change to when we know how we'll use this feature. If we'll use this feature.
I initially did this because I thought it would be necessary to use a different compiler on Travis to avoid having to install
arm-none-eabi-gcc
. But it turned out that the compiler we're using on Jenkins is from Ubuntu, so it was straightforward to add this compiler. I left the commit in because even if it isn't necessary now, it could be useful later.There are two ways this can be used: to substitute a different platform, or to use a compiler installed at a location outside
$PATH
. For the first use case, we should have different component names. For the second use case, the component should keep its name. My current preference is to declare that the second use case is the one that's primarily intended, and so keep the component names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I am not really convinced. If ${ARM_GCC_PREFIX} is set up to a value that has nothing to do with arm_none_eabi_gcc then the component has nothing to do with arm_none_eabi_gcc but is called component_build_arm_none_eabi_gcc () which is confusing to me.
Regarding the second use case, making the path to arm_none_eabi_gcc configurable would be enough it seems.
I understand that we are not completely committed to the second use case thus the idea to let it not very well defined yet. But we then go from a situation where things are clear to a situation where things are unclear: the component is named component_build_arm_none_eabi_gcc () but it may not use at all arm_none_eabi_gcc compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming
ARM_GCC_PREFIX
toARM_NONE_EABI_GCC_PREFIX
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be fine by me with this renaming.