Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -Wformat-signedness when gcc > 5 #3479

Merged
merged 1 commit into from
Jul 3, 2020
Merged

add -Wformat-signedness when gcc > 5 #3479

merged 1 commit into from
Jul 3, 2020

Conversation

okhowang
Copy link
Contributor

@okhowang okhowang commented Jul 3, 2020

Fixes #3478

Signed-off-by: okhowang(王沛文) [email protected]

Notes:

  • Pull requests cannot be accepted until the PR follows the contributing guidelines. In particular, each commit must have at least one Signed-off-by: line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

A few sentences describing the overall goals of the pull request's commits.

Status

READY

Requires Backporting

Yes

Migrations

NO

Additional comments

Todos

  • Tests
  • Documentation
  • Changelog updated
  • Backported

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

gilles-peskine-arm
gilles-peskine-arm requested changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message and the changelog entry. Other than that, thanks for the fix, looks good to me.

@gilles-peskine-arm gilles-peskine-arm self-assigned this Jul 3, 2020
@gilles-peskine-arm gilles-peskine-arm added bug component-platform Portability layer and build scripts needs-work labels Jul 3, 2020
@okhowang okhowang force-pushed the format-signedness branch from 1f6dfdd to 0cd8e0f Compare July 3, 2020 08:51
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Jul 3, 2020
yanesca
yanesca approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yanesca yanesca added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jul 3, 2020
@yanesca
Copy link
Contributor

yanesca commented Jul 3, 2020

CI is only failing on Mbed OS.

@yanesca yanesca merged commit 74ff13c into Mbed-TLS:development Jul 3, 2020
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jul 3, 2020
Merged
4 tasks
@okhowang okhowang deleted the format-signedness branch July 3, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanesca yanesca yanesca approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees

@gilles-peskine-arm gilles-peskine-arm

Labels
approved Design and code approved - may be waiting for CI or backports bug component-platform Portability layer and build scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-Wformat-signedness is unavailable before gcc 5
3 participants
@okhowang @yanesca @gilles-peskine-arm