X509 verify non-DNS SANs #3554
Merged
X509 verify non-DNS SANs #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
Mention explicitly that only DNS names are supported so far, and while at it explain where the name is searched. Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
mpg
added
bug
mbed TLS team
needs-review
This was referenced Aug 11, 2020
gilles-peskine-arm
approved these changes
Aug 12, 2020
3 tasks
hanno-becker
approved these changes
Aug 14, 2020
hanno-becker
removed
the
needs-review
|
@gilles-peskine-arm @hanno-arm Do you think I should mention in the ChangeLog entry that the bug was introduced in 2.18.0? We don't usually include that kind of information, but in that case it could be useful to explain why there is no corresponding ChangeLog entry in the LTS branches. Wdyt? |
|
Exceptionally merging before the backports are approved, in order to unblock external contribution in #2906. |
|
I don't think it's particularly useful. It wouldn't be the first time we fix a bug that was introduced after the last LTS. There are precedents where we say this, but I'm sure there are precedents where we don't. If someone is concerned about this, they can look at the comments on the pull request. Since this is merged, let's let it be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3498 - only the bug part.
The other part of #3498 was a feature request, already addressed in #2906 - which will need to be rebased on this PR, or on development after this PR is merged.
Status
READY
Requires Backporting
Partial: the bug was introduced in 2.18.0, so it's not present in the LTS branches, but let's backport the new test just to be extra sure.