Backport 2.16: Always revoke certificate on CRL #3562
Merged
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
gilles-peskine-arm
approved these changes
Aug 13, 2020
gilles-peskine-arm
added
bug
component-x509
needs-review
gilles-peskine-arm
requested changes
Aug 13, 2020
tests/scripts/all.sh
Outdated
| @@ -1094,6 +1094,16 @@ component_test_null_entropy () { | |||
| make test | |||
| } | |||
|
|
|||
| component_test_no_date_time () { | |||
| msg "build: default config without MBEDTLS_HAVE_TIME_DATE" | |||
| scripts/config.py unset MBEDTLS_HAVE_TIME_DATE | |||
There was a problem hiding this comment.
config.py needs to be config.pl in 2.16 and 2.7.
raoulstrackx
force-pushed
the
raoul/verify_crl_without_time_bp2.16
branch
from
0e75c4b to
2789382
Compare
gilles-peskine-arm
previously approved these changes
Aug 14, 2020
gilles-peskine-arm
removed
needs-ci
gilles-peskine-arm
changed the title
mpg
added
the
approved
gilles-peskine-arm
added
needs-work
and removed
approved
RFC5280 does not state that the `revocationDate` should be checked. In addition, when no time source is available (i.e., when MBEDTLS_HAVE_TIME_DATE is not defined), `mbedtls_x509_time_is_past` always returns 0. This results in the CRL not being checked at all. https://tools.ietf.org/html/rfc5280 Signed-off-by: Raoul Strackx <[email protected]>
raoulstrackx
dismissed stale reviews from gilles-peskine-arm and mpg
via
75475d8
raoulstrackx
force-pushed
the
raoul/verify_crl_without_time_bp2.16
branch
from
2789382 to
75475d8
Compare
mpg
approved these changes
Aug 26, 2020
mpg
added
needs-review
gilles-peskine-arm
approved these changes
Aug 26, 2020
gilles-peskine-arm
added
needs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport of #3433
RFC5280 does not state that the
revocationDateshould be checked.In addition, when no time source is available (i.e., when MBEDTLS_HAVE_TIME_DATE is not defined),
mbedtls_x509_time_is_pastalways returns 0. This results in the CRL not being checked at all.https://tools.ietf.org/html/rfc5280
Status
READY
Migrations
If there is any API change, what's the incentive and logic for it.
NO