Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHA-3 cSHAKE128 and cSHAKE256 support #5822

Open
wants to merge 78 commits into
base: development
Choose a base branch
from
Open

SHA-3 cSHAKE128 and cSHAKE256 support #5822

wants to merge 78 commits into from

Conversation

polhenarejos
Copy link
Contributor

Description

It adds support for cSHAKE128 and cSHAKE256 to SHA-3 module, with function-names and customization strings.
Test vectors also added.

Splitted from #5800.
Requires #5821.

Status

READY

Requires Backporting

NO

Migrations

NO

Additional comments

Any additional information that could be of interest

Todos

  • Tests
  • Documentation
  • Changelog updated

@polhenarejos polhenarejos mentioned this pull request May 8, 2022
Open
3 tasks
@polhenarejos polhenarejos changed the title Sha3 cshake SHA-3 cSHAKE128 and cSHAKE256 support May 8, 2022
@polhenarejos polhenarejos mentioned this pull request May 8, 2022
Closed
7 tasks
@tom-cosgrove-arm tom-cosgrove-arm added enhancement needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests Community needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits priority-scheduled This PR is big - it will require time to be scheduled for review needs-preceding-pr Requires another PR to be merged first and removed priority-medium Medium priority - this can be reviewed as time permits labels May 9, 2022
@gilles-peskine-arm gilles-peskine-arm removed the needs-ci Needs to pass CI tests label May 13, 2022
@d3zd3z
Copy link
Contributor

d3zd3z commented May 16, 2022

I think this might have been a little overly-agressively split into multiple PRs, since #5820, and #5821 are just the beginning commits of this change. I'll put my comments in this one, and I suggest just closing the other two, as all of the changes for SHA-3 are in this PR.

d3zd3z
d3zd3z reviewed May 16, 2022
View reviewed changes
@polhenarejos
SHA-3 does not use SHA3_ALT anymore.
1cd176d 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
olen = 0 is not allowed for SHA-3.
c475c33 
Sanity checks are moved to mbedtls_sha3_xxx() functions.

Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Fix when no SHA3 family is found.
45bf67c 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'sha3' into sha3-shake
938537e
@polhenarejos
Not used anymore.
4528240 
Signed-off-by: Pol Henarejos <[email protected]>
polhenarejos added 28 commits May 5, 2023 16:01
@polhenarejos
Merge branch 'sha3' into sha3-shake
6d98d79
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
6b4c6b0
@polhenarejos
Merge branch 'sha3' into sha3-shake
1ec01f4
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
fabd3eb
@polhenarejos
Merge branch 'development' into sha3-shake
9a9e957 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
a5704c3 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'development' into sha3-shake
ceafbe5
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
193d289
@polhenarejos
Merge branch 'development' into sha3-shake
f4df1e5
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
a77eda7
@polhenarejos
Merge tag 'v3.5.0' into sha3-shake
96ef077 
Mbed TLS 3.5.0

Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
a6d3d1e 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'development' into sha3-shake
819a7a6
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
1035562
@polhenarejos
Merge branch 'development' into sha3-shake
fb0c96d 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
0c8fbe3 
Signed-off-by: Pol Henarejos <[email protected]>
@polhenarejos
Merge branch 'development' into sha3-shake
738dfb5
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
92c15a6
@polhenarejos
Merge branch 'development' into sha3-shake
3a38aaf
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
ecf26ae
@polhenarejos
Merge branch 'development' into sha3-shake
81edcf9
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
859d843
@polhenarejos
Merge branch 'development' into sha3-shake
b66133b
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
5da872c
@polhenarejos
Merge branch 'development' into sha3-shake
8e72ae0
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
ee4290e
@polhenarejos
Merge branch 'development' into sha3-shake
ab733ec
@polhenarejos
Merge branch 'sha3-shake' into sha3-cshake
e731fb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3zd3z d3zd3z d3zd3z left review comments

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component-crypto Crypto primitives and low-level interfaces enhancement needs-preceding-pr Requires another PR to be merged first needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-scheduled This PR is big - it will require time to be scheduled for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@polhenarejos @d3zd3z @tom-cosgrove-arm @daverodgman @gilles-peskine-arm @bensze01