Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace win32 functions that are not allowed in windows 10 apps #635

Closed
wants to merge 3 commits into from

Conversation

joycepg
Copy link

@joycepg joycepg commented Oct 2, 2016

In the Universal Windows Platform (UWP), only a subset of WIN32 API is available. FindFirstFile is not allowed, but FindFirstFileEx is allowed. Also lstrlen is not allowed. Attempting to use them will fail at link time of the app.
This pull request changes the use of the banned APIs to ones that work on all versions of Windows (desktop apps and Windows Store apps (also known as Universal Windows Applications or UWA)).

@simonbutcher
Copy link
Contributor

Thanks for the contribution! To accept this we'll need to review the contribution and may need some modifications (which we may do ourselves), but first to accept or any future contributions we will need a Contributor’s Licence Agreement (CLA) signed or authorised by yourself. You can find an agreement to sign here, which can be signed and returned to us, or you could create an mbed account and accept a slightly different agreement here with a click through if this is a personal contribution.

Thanks for your understanding!

@joycepg
Copy link
Author

joycepg commented Oct 17, 2016

I have emailed a scan of the signed agreement to the email address on the form.

@joycepg
Copy link
Author

joycepg commented Nov 14, 2017

i notice that a similar pull request #730 was opened a few months after this.

also, one of my changes is now no longer required - Microsoft have since added FindFirstFile to the allowed APIs for Store Apps.

@mazimkhan mazimkhan self-assigned this Mar 21, 2018
@mazimkhan
Copy link

Closing as change no longer required and rework already going on in #730 and #1453.

@mazimkhan mazimkhan closed this Mar 21, 2018
iameli pushed a commit to livepeer/mbedtls that referenced this pull request Dec 5, 2023
do not use system include for srtp_priv.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants