Add missing ret code checks in PEM module #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresag01
force-pushed
the
iotssl-1169-pem-missing-checks
branch
from
8d37954 to
25a48aa
Compare
|
The CI failure is expected, refer to this for more information. |
yanesca
requested changes
Mar 7, 2017
tests/suites/test_suite_pem.data
Outdated
|
|
||
| PEM read (malformed PEM) | ||
| depends_on:MBEDTLS_DES_C:MBEDTLS_CIPHER_MODE_CBC | ||
| mbedtls_pem_read_buffer:"-----BEGIN EC PRIVATE KEY-----":"-----END EC PRIVATE KEY-----":"-----BEGIN EC PRIVATE KEY-----\nProc-Type\: 4,ENCRYPTED\nDEK-Info\: DES-CBC,AA94892A169FA426\n\nMAAA\n-----END EC PRIVATE KEY-----":"pwd":MBEDTLS_ERR_DES_INVALID_INPUT_LENGTH |
There was a problem hiding this comment.
I think that we could achieve full coverage of the changes with minimal effort if we would add a very similar test vector for DES3 and AES as well.
andresag01
force-pushed
the
iotssl-1169-pem-missing-checks
branch
from
25a48aa to
56e942e
Compare
|
Added tests suggested by @yanesca |
yanesca
approved these changes
Mar 9, 2017
added 2 commits
May 30, 2017 16:40
Add missing return code checks in the functions pem_des_decrypt(), pem_3des_decrypt() and pem_aes_decrypt() so that the calling function mbedtls_pem_read_buffer() is notified of errors reported by the crypto primitives AES, DES and 3DES.
andresag01
force-pushed
the
iotssl-1169-pem-missing-checks
branch
from
56e942e to
a3b9adb
Compare
|
Rebased fix on top of development branch |
This was referenced May 30, 2017
4 tasks
RonEld
approved these changes
Sep 25, 2017
|
CI failed only due to timing tests (known issue), ok to merge |
daverodgman
pushed a commit
that referenced
this pull request
Jul 7, 2021
Use constant-time look-up in modular exponentiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing return code checks in the functions pem_des_decrypt(),
pem_3des_decrypt() and pem_aes_decrypt() so that the calling function
mbedtls_pem_read_buffer() is notified of errors reported by the crypto
primitives AES, DES and 3DES.
NOTES: