Fix compiler warnings in test_suite_pk.function #9250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Uziunaite <[email protected]>
eleuzi01
added
bug
component-crypto
Signed-off-by: Elena Uziunaite <[email protected]>
eleuzi01
added
needs-review
sezrab
requested changes
Jun 17, 2024
We do not normally do changelog entries for test code. We should have 3.6 backports though. |
sezrab
previously approved these changes
Jun 17, 2024
4 tasks
|
We don't write changelog entries for test improvements, but this is a build failure, and it's user-reported, so I think we should have a changelog entry. |
gilles-peskine-arm
added
needs-backports
Signed-off-by: Elena Uziunaite <[email protected]>
Done, let me know if it's good. |
| @@ -0,0 +1,3 @@ | |||
| Bugfix | |||
| * Fix redefinition warnings when SECP192R1 and/or SECP192K1 are disabled. | |||
| Fixes #9029. | |||
There was a problem hiding this comment.
The last line is missing a newline at the end. That confuses some tools including assemble_changelog.py.
Signed-off-by: Elena Uziunaite <[email protected]>
eleuzi01
removed
the
needs-backports
eleuzi01
added
needs-ci
eleuzi01
added
needs-ci
|
Ignoring Open CI fail, as internal passed. |
Merged
via the queue into
Mbed-TLS:development
with commit Jun 24, 2024
d9392f0
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix for compiler warnings in test_suite_pk.function when SECP192R1 or/and SECP192K1 are disabled, see #9029
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: