Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 3.6] Use CMAKE_C_SIMULATE_ID when available to determine compiler #9273

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[Backport 3.6] Use CMAKE_C_SIMULATE_ID when available to determine compiler #9273

merged 1 commit into from
Jun 24, 2024

Conversation

eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented Jun 17, 2024 •
edited
Loading

Description

Trivial 3.6 backport of #8389

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required
  • 3.6 backport not required
  • 2.28 backport not required
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 mentioned this pull request Jun 17, 2024
Merged
4 tasks
@eleuzi01 eleuzi01 added enhancement component-platform Portability layer and build scripts needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Jun 17, 2024
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - faithful backport

@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Jun 18, 2024
@eleuzi01 eleuzi01 requested a review from tom-daubney-arm June 24, 2024 09:41
@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jun 24, 2024
tom-daubney-arm
tom-daubney-arm approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jun 24, 2024
@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Jun 24, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 71b5818 Jun 24, 2024
6 checks passed
@thrimbor thrimbor mentioned this pull request Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-platform Portability layer and build scripts enhancement priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eleuzi01 @tom-daubney-arm @tom-cosgrove-arm @daantimmer